search

sablier-labs / flow

🍃 Smart contracts of the Sablier Flow protocol.
Other
8 stars 0 forks source link

Investigate failing tests #289

Open smol-ninja opened 2 weeks ago

smol-ninja commented 2 weeks ago
smol-ninja commented 6 days ago

Once again a failed invariant: https://github.com/sablier-labs/flow/actions/runs/11315197709/job/31466098930

@andreivladbrg have you made up your mind about invariant_TotalStreamedWithDelayEqTotalDebtPlusWithdrawn to test for inequality instead of equality?

smol-ninja commented 5 days ago

IMO lets go with inequality now. The failing tests won't look well during the public contest. We understand the problem, what is causing it but due to uncertainty in wei lost in a stream (1 / 2 amount), we are not able to pin point a concrete solution. The inequality guarantees that the precision error is within a limit.

Lets create another issue to track a concrete solution for this problem.

andreivladbrg commented 5 days ago

tests won't look well during the public contest

agree, let’s temporarily remove the delay logic in the invariant; i’ll think of a way to properly test equality (if it is possible) this after the audit. the inequality works as well