Change types and add modifier to getter

sablier-labs / flow

🍃 Smart contracts of the Sablier Flow protocol.

Other

10 stars 2 forks source link

Change types and add modifier to getter #296

Closed andreivladbrg closed 1 month ago

andreivladbrg commented 1 month ago

Closes #295

Changes

fix: use uint256 for scaledOngoingDebt
fix: add notNull in isTransferable getter
fix: use uint256 in depletionTimeOf

andreivladbrg commented 1 month ago

@smol-ninja While going through the code again, I realized I made some errors in the fixes and force-pushed my initial commit (your review comments might be outdated now—sorry).

These issues should have been addressed, but the changes caused some tests to break. I still need to debug that as well

andreivladbrg commented 1 month ago

@smol-ninja just finished with the test fixes

since this finding https://cantina.xyz/code/99ae802b-f05c-4e36-a1d1-240d5146649c/findings/8 is also related to the depletionTimeOf function, and the fix is small, should we also address this in this PR

smol-ninja commented 1 month ago

Sounds good. Took me a while to understand the context of finding. It was confusing to me.

andreivladbrg commented 1 month ago

As we discussed over slack, given that snapshotDebt has its own slot, are you not considering using uint256 for it, so as to avoid downcasting while storing to it?

Lets include https://cantina.xyz/code/99ae802b-f05c-4e36-a1d1-240d5146649c/findings/8 in this PR as well

@smol-ninja just pushed a new commit cdedfd1c40ce8abd5b9282065206be717385f9f7