search

sablier-labs / flow

🍃 Smart contracts of the Sablier Flow protocol.
Other
10 stars 2 forks source link

docs: update protocol assumptions #316

Closed smol-ninja closed 1 month ago

smol-ninja commented 1 month ago

Update protocol assumption post Cantina finding. Also added assumption about tokens with admin powers as pointed by @razgraf on Slack.

Closes https://github.com/sablier-labs/flow/issues/310.

@andreivladbrg I have replaced the "delay" keyword with "precision errors" and "loss" as thats what Cantina auditors used in their submissions. I think these terms are easier to follow compared to "delay" keywords.

smol-ninja commented 1 month ago

Yeah go ahead @PaulRBerg

PaulRBerg commented 1 month ago

Thanks, good to merge now.

We might want to add the same assumption about the admin in the Lockup security document.

smol-ninja commented 1 month ago

Thank you.

Yes there is a separate issue to track that: https://github.com/sablier-labs/v2-core/issues/1065.