search

sablier-labs / reusable-workflows

Reusable workflows to use in GitHub Actions
18 stars 3 forks source link

chore: update github actions to v4 #3

Closed smol-ninja closed 3 months ago

smol-ninja commented 4 months ago

Closes https://github.com/sablier-labs/reusable-workflows/issues/2 and https://github.com/sablier-labs/v2-core/issues/812.

PaulRBerg commented 3 months ago

Thanks, Shub. Sorry, I missed this because I wasn't watching this repository.

There's one issue with this PR. In codecov-action V4, tokenless uploads are no longer allowed. ~I've pushed a commit to address this, and I've also added the requisite environment variables in V2 Core and V2 Periphery~.

I couldn't push to your fork because you created the PR against main:

https://app.warp.dev/block/jileGq6Wbwhgr5sAp8M6wI

~edit For future PRs, just create a new branch in the Sablier repo directly (you should have access to do this). Or create a new branch in your fork.~

edit 2: looks you didn't have permission. Sorry for that, sorted now.

PaulRBerg commented 3 months ago

Closing in favor of https://github.com/sablier-labs/reusable-workflows/pull/6.