As per @cleanunicorn's report on the 16th of September.
[x] Add comments for 1e16 and 1e18, the mantissa percentage system
[x] Add comment about the time unit of the value returned by deltaOf
[x] Fix the UdateFeeLocalVars typo
[x] Rename compoundingStreamVars.underlyingRate to compoundingStreamVars.underlyingRatePerSecond (part of the CompoundingStreamVars struct)
[x] Rename newFee to feePercentage, senderShare to senderSharePercentage and recipientShare to recipientSharePercentage to better signal that these variables are a percentage
[x] Rename nonce to nextStreamId
[x] Rename stream.balance to stream.remainingBalance (part of the Stream struct)
[x] Rename stream.rate to stream.ratePerSecond (part of the Stream struct)
This PR also updates all references to these updated variables in the JavaScript tests.
As per @cleanunicorn's report on the 16th of September.
1e16
and1e18
, the mantissa percentage systemdeltaOf
UdateFeeLocalVars
typocompoundingStreamVars.underlyingRate
tocompoundingStreamVars.underlyingRatePerSecond
(part of the CompoundingStreamVars struct)newFee
tofeePercentage
,senderShare
tosenderSharePercentage
andrecipientShare
torecipientSharePercentage
to better signal that these variables are a percentagenonce
tonextStreamId
stream.balance
tostream.remainingBalance
(part of the Stream struct)stream.rate
tostream.ratePerSecond
(part of the Stream struct)This PR also updates all references to these updated variables in the JavaScript tests.