Add stream withdrawal support

sablier-labs / v1-safe-app

Safe App for interacting with the Sablier protocol

https://sablier-v1-safe-app.vercel.app

GNU General Public License v3.0

19 stars 7 forks source link

Add stream withdrawal support #28

Closed TomAFrench closed 4 years ago

TomAFrench commented 4 years ago

In the MVP we only allow Safes to create streams, there is no way for them to receive a stream and withdraw from it. This will be a commonly used feature so should be added in v1.0.

required steps:

[ ] add new graphql query to get incoming streams
[ ] create new set of table columns for incoming streams ("From" rather than "To")
[ ] add interface to switch between showing outgoing and incoming streams
[ ] Add a withdrawFromStreamfunction similar to cancelStream

PaulRBerg commented 4 years ago

Hmm... the catch is that Sablier v2 (the core protocol) will deprecate withdrawals once and for good. Sablier tokens will be "holdable" in any wallet, not requiring users to be cognisant of any Sablier-derived product anymore.

Furthermore, I know that Gnosis has been marching on making the Safe a more consumer-oriented product, but I still suspect that most of their users are 2+ person teams, hence why creating streams is essential but withdrawing not so much.

TomAFrench commented 4 years ago

Furthermore, I know that Gnosis has been marching on making the Safe a more consumer-oriented product, but I still suspect that most of their users are 2+ person teams, hence why creating streams is essential but withdrawing not so much.

True, although the relative work to allow withdrawals would be relatively small once the outgoing stream display is completed.

Hmm... the catch is that Sablier v2 (the core protocol) will deprecate withdrawals once and for good. Sablier tokens will be "holdable" in any wallet, not requiring users to be cognisant of any Sablier-derived product anymore.

Ah yes, I forgot about this aspect. I'm happy to drop this.