search

sablier-labs / v1-safe-app

Safe App for interacting with the Sablier protocol
https://sablier-v1-safe-app.vercel.app
GNU General Public License v3.0
19 stars 7 forks source link

Token balance incorrect for the Safe address #31

Closed PaulRBerg closed 4 years ago

PaulRBerg commented 4 years ago

My Rinkeby Safe wallet is 0xbaF500a5e009ca6892f6B49227b56f88215c9e61.

As you can see by dropping that address in the "balanceOf" function of the TestnetDAI token, the balance of the Safe is:

47200.000000000996693000

And not:

1999600000.0000

The latter is displayed in the UI, the former is the actual balance.

I think the bug here is that the token balance corresponds to the end user, not the Safe.

PaulRBerg commented 4 years ago
Capture d’écran 2020-06-05 à 00 18 59
TomAFrench commented 4 years ago

Yeah, somehow it's getting past the process.env.NODE_ENV !== "production" && process.env.REACT_APP_LOCAL_WEB3_PROVIDER check in the useAppsSdk hook although if I console.log process.env.REACT_APP_LOCAL_WEB3_PROVIDER right after it then it shows as false

PaulRBerg commented 4 years ago

It may be a bug that occurs only in development. I'll mark it as "stale" for now.