search

sablier-labs / v1-safe-app

Safe App for interacting with the Sablier protocol
https://sablier-v1-safe-app.vercel.app
GNU General Public License v3.0
19 stars 7 forks source link

Compress stream length component size #9

Closed TomAFrench closed 4 years ago

TomAFrench commented 4 years ago

Currently we have several Select boxes for each time increment in the stream creation UI, this is contributing to us overflowing the available area (and doesn't look great besides).

One way to handle this is to pull in the equivalent component from pay.sablier.finance

Screenshot_2020-05-29_19-29-27

@PaulRBerg are you happy for us to pull that component across and restyle it to match the gnosis style?

TomAFrench commented 4 years ago

I've had a chat with one of the Gnosis guys on their discord and they're going to be looking at relaxing the current hard 476px limit for the app height (I'm currently expecting to end up somewhere around 550px after this change).

PaulRBerg commented 4 years ago

are you happy for us to pull that component across and restyle it to match the gnosis style?

Absolutely, I'll take care of this. It'd be cool if I managed to share that component as part of a components library on npm, but I'm not yet sure if I'll have time for htat.

I've had a chat with one of the Gnosis guys on their discord and they're going to be looking at relaxing the current hard 476px limit

Great. Is it that now you can't even scroll apps? You are literally forced to fit all vertical content in 476px?

TomAFrench commented 4 years ago

If we overflow the boundaries then we'll get scrollbars on the iframe. We don't have to worry too much during development but obviously we we don't want this at ship time.

PaulRBerg commented 4 years ago

Big progress on this today! I'll create a PR In a bit.

I considered shipping this duration input as part of Sablier v1 components library, but the effort wasn't worth it, particularly because we'll change the UI for v2.

So this will be a mere component in this repository.