search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
306 stars 42 forks source link

Rename `MerkleLockup` integration tests to include Lockup type #1000

Closed smol-ninja closed 1 month ago

smol-ninja commented 4 months ago

The contract names in the MerkleLockup integration tests do not include the name of the Merkle Lockup that they run tests for. Take the following example:

https://github.com/sablier-labs/v2-core/blob/a97e5ae278e82a91533d42ae4df2cd3f95c14f81/test/periphery/integration/merkle-lockup/ll/clawback/clawback.t.sol#L9

is same as

https://github.com/sablier-labs/v2-core/blob/a97e5ae278e82a91533d42ae4df2cd3f95c14f81/test/periphery/integration/merkle-lockup/lt/clawback/clawback.t.sol#L9

I suggest to renaming them to include the name of the Merkle Lockup i.e.

  1. In ll folder -> Clawback_MerkleLL_Integration_Test
  2. In lt folder -> Clawback_MerkleLT_Integration_Test

and so on.

andreivladbrg commented 4 months ago

Since the tests are duplicated for this function (maybe there are more) shouldn't we add a shared dir at: test/integration/merkle-lockup/shared/?

smol-ninja commented 4 months ago

Good idea.