search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
314 stars 48 forks source link

Remove Merkle Lockup contracts from this repo #1072

Closed smol-ninja closed 1 week ago

smol-ninja commented 1 month ago

Originally discussed in https://github.com/sablier-labs/v2-core/discussions/1068

Remove merkle lockup contracts from this repo.

andreivladbrg commented 1 month ago

Should we make this change after we finish all 2.0.0 features and changes?

smol-ninja commented 1 month ago

Sounds good.

smol-ninja commented 2 weeks ago

I am working on this.

andreivladbrg commented 2 weeks ago

wouldn't it be better to do it after https://github.com/sablier-labs/v2-core/pull/1084 ? so that you don't copy testing logic related to batch? also, so we can remove core dir

smol-ninja commented 2 weeks ago

As a part of this PR, this is what I am thinking:

While adding to v2-periphery, I will only copy whats relevant to merkle lockup contracts. While removing it in this PR, it does not seem to me that there will be many conflicts and if there will be I will resolve them.

The advantage is that some issues are related airdrops only which can be done in parallel. As of now, since they all share common tests, working synchronously is difficult.

PaulRBerg commented 2 weeks ago

We shouldn't rename v2-periphery to airdrops. We should create a separate repository and archive V2 Periphery.

smol-ninja commented 2 weeks ago

@PaulRBerg sounds good.

@andreivladbrg removing core dir is a part of https://github.com/sablier-labs/v2-core/issues/1073 (sorry I missed thar question)

And I will only copy tests logic related to merkle lockup contracts.

smol-ninja commented 2 weeks ago

I have renamed this issue and created relevant in the airdrops repo: https://github.com/sablier-labs/airdrops/issues

PaulRBerg commented 1 week ago

Closed by #1089