search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
309 stars 45 forks source link

Investigate why these remappings appear on the Etherscan verification reports #585

Closed PaulRBerg closed 7 months ago

PaulRBerg commented 1 year ago

During a recent deployment, I noticed that the "Settings" section on Etherscan reports a lot of remappings that have nothing to do with V2 Core:

Screenshot 2023-08-23 at 10 29 57 AM

This is strange because some of those remappings reference dependencies that are not longer used by V2 Core (e.g. @prb/contracts), and others whichthat have never been part of V2 Core (e.g. @prb/proxy).

Potential explanations:

  1. Etherscan caching bug
  2. Forge caching bug (Forge's state is somehow persistent across different workflow runs, including across different repos)
PaulRBerg commented 1 year ago

Related: https://github.com/foundry-rs/foundry/issues/5258

andreivladbrg commented 7 months ago

Since we are no longer using git submodules, we don't face this issue anymore. See the LockupLinear contract

image

The only imports that appear are actually our configurations. Should we close this? @PaulRBerg

PaulRBerg commented 7 months ago

Yep, let's close this.

It's also possible that they fixed this bug in Forge in the meantime. But the issue is fixed so either way, it doesn't matter.