search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
311 stars 47 forks source link

Regenerate SMTChecker report #704

Open PaulRBerg opened 1 year ago

PaulRBerg commented 1 year ago

Investigate why it is failing:

https://github.com/sablier-labs/v2-core/actions/runs/6213048327

PaulRBerg commented 1 year ago

@andreivladbrg I would really like to generate this SMTChecker report before the audits start in November. Can you please work on this task?

andreivladbrg commented 1 year ago

yes, next on my list

andreivladbrg commented 1 year ago

I've been attempting to compile this full report for a couple of days now, but it simply won't complete. I even left my laptop on overnight to run the full report, but it didn't work for the lockupDynamic contract.

I'll leave the report for the linear contract below:

smtchecker-report-linear.txt

The result is odd, especially given that we have this configuration: https://github.com/sablier-labs/v2-core/blob/91887daff5872c7fa83fe3644b6f7582e9bffc0d/foundry.toml#L55-L57

I suspect this issue is related to the new Solidity version 0.8.21 we are using, it might not be fully supported yet.

PaulRBerg commented 1 year ago

I was expecting the report generation to take a long time.

But yes, the report is strange.

Don't worry in this case, I will pick up this task later. Thanks for your help.

PaulRBerg commented 11 months ago

We should upload the SMTChecker report in the docs.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 182 days with no activity. Leave a comment or remove the "stale" label, otherwise this will be closed in 14 days.

PaulRBerg commented 3 months ago

I'll handle this