Inconsistency in the order of parameters in structs between LockupLinear and LockupDynamic

[andreivladbrg]

We should have a consistent order of parameter structs:

• Sender
• Recipient
• Total Amount
• Asset
• Cancelable
• Transferable
• Time-related variables
• Broker

LD:

https://github.com/sablier-labs/v2-core/blob/e1a53b4c839912573996c313d447aeeed6eb434c/src/types/DataTypes.sol#L111-L121

LL:

https://github.com/sablier-labs/v2-core/blob/e1a53b4c839912573996c313d447aeeed6eb434c/src/types/DataTypes.sol#L223-L232

[PaulRBerg]

Isn't the difference due to gas efficiency reasons?

[andreivladbrg]

These structs are the ones passed in the create functions, the order of loading parameters in the stack does not affect the gas prices. Let's not confuse with the storage Stream structs

[PaulRBerg]

That's fair - an explanation in the OP would have been helpful

[PaulRBerg]

Pasting @smol-ninja's comment from here:

If I may answer your answer @PaulRBerg, since struct CreateWithDurations is only used in memory or on the stack (and never storage), the order of parameters does not affect gas usage. Each variable has its own slot.

So ordering does not matter here.