search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
292 stars 40 forks source link

CI: Investigate fork tests for PRs by external contributors #745

Closed smol-ninja closed 4 months ago

smol-ninja commented 7 months ago

Context

Fork testing fails on a PR raised by external contributors despite them setting up the correct Github Secrets in their local repo. This is because Secrets are not passed from the source branch to the workflows. Source ↗.

There is an alternate approach to using pull_request_target instead of the pull_request event in GitHub Actions to enable the workflow to operate within the context of the contributor's secrets. The risk involved is that it can lead to the repo's GitHub secrets. More info ↗

Investigate if there is a safer way to enable fork testing for external PRs.

Some references: #1 #2 #3

smol-ninja commented 4 months ago

Closing this since we are no longer running fork tests on every PR. Ref: https://github.com/sablier-labs/v2-core/commit/897bca6a1fefedf2cb1059cc48a9f65126fa33bb