search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
292 stars 40 forks source link

Adjust versions in the NFT descriptor #820

Closed PaulRBerg closed 5 months ago

PaulRBerg commented 5 months ago

This is a child issue of https://github.com/sablier-labs/v2-core/issues/808.

The task is to adjust the description generated in the NFT descriptor to account for the package tethering, i.e., say LockupLinear v1.1.2 instead of Sablier V2:

https://github.com/sablier-labs/v2-core/blob/d5aea835dfe32b6cffa1c8cb40a7ba458f4ab5ee/src/SablierV2NFTDescriptor.sol#L261-L279

andreivladbrg commented 5 months ago

Let's add this issue as a comment in the main one, there is no need to create a separate one

PaulRBerg commented 5 months ago

@andreivladbrg but @smol-ninja has suggested opening separate issues for each subtask.

I don't mind either way. You should resolve it between the two of you.

smol-ninja commented 5 months ago

As discussed privately, we decided to create multiple PRs for #808 instead of creating multiple sub-issues for it.