search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
308 stars 44 forks source link

Replace PRBTest with native Foundry assertions #842

Closed PaulRBerg closed 6 months ago

PaulRBerg commented 6 months ago

Forge Std v1.8.0 has been released recently.

It comes with a wonderful new feature: native Foundry assertions! They got rid of DSTest.

This has motivated me to deprecate PRBTest, hence why I also opened this issue here to replace PRBTest with the native assertions available in Foundry now.

Related:

andreivladbrg commented 6 months ago

This has motivated me to https://github.com/PaulRBerg/prb-test/issues/45

so, it means one less dep?

this issue requires to update the forge-std lib, thus more changes would be needed (just saying)

PaulRBerg commented 6 months ago

it means one less dep?

Yeah

smol-ninja commented 6 months ago

We would also have to replace PRBTest with native Foundry's StdAssertions in prb-math as a requirement to this.

PaulRBerg commented 6 months ago

I'm OK with that.

smol-ninja commented 6 months ago

I have created a PR (#222) to update forge-std in prb-math.

PaulRBerg commented 6 months ago

Thanks for that, reviewed it now.