docs: roll 1.2.0 - Githubissues

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol

https://sablier.com

Other

289 stars 38 forks source link

docs: roll 1.2.0 #863

Closed smol-ninja closed 6 hours ago

smol-ninja commented 3 months ago

Changelog

Closes https://github.com/sablier-labs/v2-core/issues/861.
Closes https://github.com/sablier-labs/v2-core/issues/770.

andreivladbrg commented 3 months ago

This PR is WIP, we may add changes to it.

yes, if there are findings in the audit, this would be changed, so i would leave this on the backlog until the audit is finished. is it ok?

smol-ninja commented 3 months ago

Of course. I don't expect it to be merged before the audit. I should have added WIP in the title.

smol-ninja commented 2 months ago

@PaulRBerg I've updated the change logs for you to review.

PaulRBerg commented 2 months ago

Thank you very much @smol-ninja.

As discussed previously, we will review and merge this PR after the private audit is finished.

smol-ninja commented 2 weeks ago

I have updated this PR. Also, updated change date for BUSL license cc @PaulRBerg.

smol-ninja commented 2 days ago

@andreivladbrg feel free to give it a last look (hopefully).

smol-ninja commented 1 day ago

I am thinking if we should merge these points into a single one:

I agree. But any idea whats the best way to do it? I thought about it as well but couldn't come up with a way to do that without moving away from the common changelog practices.

andreivladbrg commented 1 day ago

I agree. But any idea whats the best way to do it? I thought about it as well but couldn't come up with a way to do that without moving away from the common changelog practices

I was looking at OZ release and I think we can do the same (under Changed):

Breaking: use a new hook system (https://github.com/sablier-labs/v2-core/pull/951)
- Replace ISablierV2Recipient with ISablierLockupRecipient hook interface
- Don't use try..catch block anymore

wdyt?

smol-ninja commented 1 day ago

I like it. Would you like to push a commit to include your ideas?

andreivladbrg commented 1 day ago

pushed a new commit to address my feedback a1b7b072bc462d1d2f9af4b536445925b50af5b5

lmk if it looks good

smol-ninja commented 11 hours ago

Looks good to me @andreivladbrg . I have removed space between lines from the "Changed" section.

smol-ninja commented 7 hours ago

We should also add the following:

Refactor create functions to createWithTimestamps and createWithDurations across all lockup contracts

I think this is a big change.

wdyt @andreivladbrg?

andreivladbrg commented 6 hours ago

yes, we should

f91be4059010b46ed4f89d9d8876f3bbdd9701ac