Update forge-std to v1.8.1

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol

https://sablier.com

Other

308 stars 44 forks source link

Update forge-std to v1.8.1 #865

Closed smol-ninja closed 6 months ago

smol-ninja commented 6 months ago

Closes #842, #843, #866 and https://github.com/sablier-labs/v2-core/issues/747 (1st task only).

Subtasks

Notable changes

Remove @prb/test dep
Use StdAssertions log events

Other changes

Rename timestamp to newTimestamp in vm.warp
Rename assumeNoPrecompiles to assumeNotPrecompile

smol-ninja commented 6 months ago

@PaulRBerg, I have incorporated your suggestions.

smol-ninja commented 6 months ago

Yes @andreivladbrg. I've created a separate issue for that.

https://github.com/sablier-labs/v2-core/issues/866

andreivladbrg commented 6 months ago

Yes @andreivladbrg. I've created a separate issue for that.

I am sorry. I've missed that issue.

smol-ninja commented 6 months ago

In forge-std, there is a contract called CommonBase which offers vm as an internal variable.

Should I delete BaseVm and inherit from CommonBase or should we continue to keep BaseVm?

andreivladbrg commented 6 months ago

In forge-std, there is a contract called CommonBase which offers vm as an internal variable. Should I delete BaseVm and inherit from CommonBase or should we continue to keep BaseVm?

IMO we should delete BaseVm, and use CommonBase

PaulRBerg commented 6 months ago

agree with @andreivladbrg