search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
289 stars 38 forks source link

Single test default used for two different constants #870

Closed PaulRBerg closed 2 months ago

PaulRBerg commented 3 months ago

The MAX_COUNT default is used for both MAX_SEGMENT_COUNT and MAX_TRANCHE_COUNT:

https://github.com/sablier-labs/v2-core/blob/e080f20eafef0fc18049bcc77f1694db043860f1/test/utils/Defaults.sol#L26

This is not good because there can be more tranches than segments (as discussed here).

We should have two different defaults.