Open smol-ninja opened 4 months ago
LGTM except for the error name.
I would create two errors, one for withdrawals, and another for cancellations.
I'd also say something like InvalidWithdrawalInBatch
@smol-ninja could you please create a milestone for the next Lockup release, and include this issue in that milestone?
And let's name it according to the package tethering approach.
Will do.
Did you mean board or milestone @PaulRBerg?
We used board to track v2.2, which I have created one here: https://github.com/orgs/sablier-labs/projects/19/views/2. I am calling it Lockup 1.2.1
but if it ends up being a big release (depending on the issues and features we add to it), we can rename it to Lockup 1.3.0
.
Note the description: Tracking bugs, new ideas and feature requests for Sablier Lockup 1.2.1 which will succeed 1.2.0 (also known as V2.2)
Sorry, I meant a board.
The name sounds good.
This feature would mitigate L-07. WithdrawMultiple can be DOS'ed by a random user from the CodeHawk report, wouldn't it?
Yes.
As discussed here, batch functions such as
cancelMultiple
andwithdrawMultiple
should be allowed to continue execution if one of the stream IDs revert.A sample implementation would look like the following: