search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
288 stars 38 forks source link

Address feedback #918

Closed andreivladbrg closed 1 month ago

andreivladbrg commented 1 month ago

The motivation behind this PR was to better organize the repo, making it faster and more robust.

This PR changes the test/benchmarks by moving all files related to benchmarks into their own directory, including files from both the test and script. The main reason is to allow the benchmark Foundry profile to isolate tests and benchmarks, thereby reducing long run times. Additionally, I removed the estimate-max-count.sh script since we now use forge's console2 to log within a single CLI run, instead of running forge script for different block gas limits. To automate the process of updating the count maps, I've added the update-script-counts, which was challenging due to the number formatting in our Solidity files (using underscores).

I've also removed the .gas.snapshot file, as we now have more accurate tables.

PaulRBerg commented 1 month ago

I will let @smol-ninja review this

smol-ninja commented 1 month ago

I am merging it. We can review the changes in other PR now before finally merging that.