search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
288 stars 38 forks source link

Incorrect placement of the `_update` function #919

Closed andreivladbrg closed 1 month ago

andreivladbrg commented 1 month ago

The _update hook implemented from ERC721 is placed under CONSTANT header and it should be under NON-CONSTANT:

https://github.com/sablier-labs/v2-core/blob/350fcceddd60736193b71f576093b51f31d7b1e5/src/abstracts/SablierV2Lockup.sol#L459

https://github.com/sablier-labs/v2-core/blob/350fcceddd60736193b71f576093b51f31d7b1e5/src/abstracts/SablierV2Lockup.sol#L522