sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
307 stars 43 forks source link

Check start time in Linear `_calculateStreamedAmount` #941

Closed andreivladbrg closed 3 months ago

andreivladbrg commented 3 months ago

Depends on #940

Closes https://github.com/sablier-labs/v2-core/issues/938

andreivladbrg commented 3 months ago

test trees must be updated to reflect the new execution paths

can you please provide more details? (it is a tricky situation here because we have common tests in lockup for this function, and individual tests in each model - linear/dynamic/tranched)

side note: we really need to start using Bulloak here

yes, it would be helpful, tho, imo it is a low priority atm

smol-ninja commented 3 months ago

We already have an open issue to use Bulloak across the repo. Its planned for the next release: https://github.com/sablier-labs/v2-core/issues/799