search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
288 stars 38 forks source link

Lockup abstract is not fully ERC-4906 compliant #947

Closed PaulRBerg closed 1 week ago

PaulRBerg commented 2 weeks ago

See L-01 finding in the CodeHawks report:

https://www.codehawks.com/report/clvb9njmy00012dqjyaavpl44#L-01

It is worth noting that OpenSea updates the SVG even without ERC-165 support. Still, for completeness' sake, we should implement ERC-4906 correctly by supporting ERC-165.