search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
288 stars 38 forks source link

perf: return 0 in linear when startTime == blockTimestamp #959

Closed andreivladbrg closed 1 day ago

andreivladbrg commented 2 days ago

Closes https://github.com/sablier-labs/v2-core/issues/958

PaulRBerg commented 22 hours ago

love the new LGTM meme games!

PaulRBerg commented 22 hours ago

Didn't we have to update some of the concrete tests?

smol-ninja commented 22 hours ago

Not in the current tree structure. This is the relevant test: https://github.com/sablier-labs/v2-core/blob/staging/test/integration/concrete/lockup-linear/streamed-amount-of/streamedAmountOf.tree and me and @andreivladbrg debated at length here about it and decided to make some changes when we refactor tests with Bulloak.