search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
291 stars 40 forks source link

Running the CI Deep workflow manually results in errors #965

Closed PaulRBerg closed 2 days ago

PaulRBerg commented 5 days ago

See the recent run: https://github.com/sablier-labs/v2-core/actions/runs/9807405025

SCR-20240705-mdqy
smol-ninja commented 5 days ago

The error is due to the syntax ${{ inputs.invariantDepth || 100 }}. It wasn't an error before so may be Github changed the way they parse digits in OR conditions.

The easiest solution is to remove the OR condition and just use ${{ inputs.invariantDepth }}. Any problem with that approach? All the inputs are anyways defined in the workflow file so having the OR condition is redundant in this case.

PaulRBerg commented 4 days ago

We have to keep using the OR syntax because otherwise inputs would be undefined when run by the weekly cron job.

I can't find it now, but there was a StackOverflow thread where I found the recommendation to use that syntax.

smol-ninja commented 4 days ago

I see. In that case, I will look for solutions.

smol-ninja commented 3 days ago

Re-opening it as its not resolved. Seems like the run works fine on automatic dispatch and only fails on manual dispatch. As an example:

  1. v2-periphery automatic dispatch: success
  2. v2-periphery manual dispatch: failure
smol-ninja commented 3 days ago

Finally, found the solutions:

  1. Core PR: https://github.com/sablier-labs/v2-core/pull/968
  2. Periphery PR: https://github.com/sablier-labs/v2-periphery/pull/366

Successful runs:

PaulRBerg commented 2 days ago

Great sleuthing @smol-ninja!