search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
311 stars 47 forks source link

Fix chain ID for Blast network #967

Closed smol-ninja closed 4 months ago

smol-ninja commented 4 months ago

See below

https://github.com/sablier-labs/v2-core/blob/fd8eb98f4f88dfbfda35f6605662d84cb885f9c1/script/Base.s.sol#L101-L103

https://github.com/sablier-labs/v2-core/blob/fd8eb98f4f88dfbfda35f6605662d84cb885f9c1/benchmark/EstimateMaxCount.t.sol#L30

The correct chain ID is 81457, source ↗.

Do the same in blast-l2 branch.

PaulRBerg commented 4 months ago

Does this mean that yesterday's deployment was incorrect and we have to redeploy?

smol-ninja commented 4 months ago

Not incorrect but with less number of segments and tranches. Chainlist had incorrect chain ID for Blast so as a result, I picked the wrong one without checking it in the Blast docs. Thats why it got deployed with the default values which is 500.

smol-ninja commented 4 months ago

Fixed https://github.com/sablier-labs/v2-core/commit/daeac7c23942ac465fd5da5d8291ecd433326e72.