search

sablier-labs / v2-core

⏳ Core smart contracts of the Sablier V2 token distribution protocol
https://sablier.com
Other
304 stars 42 forks source link

Running the CI Deep template via cron job fails #970

Closed PaulRBerg closed 1 month ago

PaulRBerg commented 1 month ago

See the latest run: https://github.com/sablier-labs/v2-core/actions/runs/9924854793

SCR-20240715-lscv

Related:

smol-ninja commented 1 month ago

Thanks for noticing. I will look into it. Do you receive the failed CI results on your email? Is there a way to forward them to tech@sablier.com so that I can also receive them?

PaulRBerg commented 1 month ago

You're welcome.

I'd prefer not to send these updates to the tech@sablier.com email address to avoid spamming the frontend team with Solidity CI failures.

I shared a pro tip on Slack about how to set up email notifications for failed CI runs.

smol-ninja commented 1 month ago

Raised an issue with the Github team: https://github.com/actions/runner/issues/3394

PaulRBerg commented 1 month ago

Thanks @smol-ninja. We might also want to reach out via GitHub Support; we're paying customers after all.

smol-ninja commented 1 month ago

Good idea. I have created a ticket with them.

smol-ninja commented 1 month ago

https://github.com/sablier-labs/v2-core/commit/a34e5287bb77c3e20b8fb9d3ef349a4a80d990aa and https://github.com/sablier-labs/v2-periphery/commit/2d338a7ff6452b20a25e779f5a960f047a5d16af should fix it now. The possible issue was that fromJSON requires if and else condition inside it.

So instead of fromJSON(inputs.integrationFuzzRuns) || 100000 it should have been fromJSON(inputs.integrationFuzzRuns || '100000').

PaulRBerg commented 1 month ago

Great! Let's see if it works next Sunday.

smol-ninja commented 1 month ago

Working now:

  1. https://github.com/sablier-labs/v2-periphery/actions/runs/10233004613
  2. https://github.com/sablier-labs/v2-core/actions/runs/10232982824/job/28310893019