Think of a way to merge the `core` and `periphery` dirs

sablier-labs / v2-deployments

Keeping track of Sablier V2 deployments

GNU General Public License v3.0

2 stars 1 forks source link

Think of a way to merge the `core` and `periphery` dirs #10

Open andreivladbrg opened 3 months ago

andreivladbrg commented 3 months ago

Ref https://github.com/sablier-labs/v2-core/pull/979

andreivladbrg commented 3 months ago

Idea:

└── deployments
    ├── lockup
    │  ├── v1.0.0 // both core and periphery
    │  └── v1.1.0 // both core and periphery 
    └── flow
       ├── v1.0.0 
       └── v1.1.0

smol-ninja commented 3 months ago

Looks good to me.

PaulRBerg commented 1 week ago

Wouldn't it be better to rename periphery to airdrops, and add a warning in <v1.2.0 that the npm package hsed to be called @sablier/v2-periphery?

andreivladbrg commented 1 week ago

this issue was created in august, at that time there was no discussion about airdrop repo (will update the OP)

PaulRBerg commented 1 week ago

OK, so you agree with my proposal?

andreivladbrg commented 16 hours ago

Wouldn't it be better to rename periphery to airdrops, and add a warning in <v1.2.0 that the npm package hsed to be called @sablier/v2-periphery?

@PaulRBerg just realized that this wouldn’t work, as the periphery used to contain the proxy contract in the earlier versions. so, IMO naming it “airdrops” would be misleading. wdyt?

we will have airdrops only for the new versions, and we can mention “previously known as periphery.”

smol-ninja commented 15 hours ago

How about moving previously deployed merkle campaign contracts to airdrops and keep rest (batch, proxy) etc in core?

andreivladbrg commented 15 hours ago

How about moving previously deployed merkle campaign contracts to airdrops and keep rest (batch, proxy) etc in core?

even more confusing IMO :))

PaulRBerg commented 15 hours ago

good point @andreivladbrg

we will have airdrops only for the new versions, and we can mention “previously known as periphery.”

Sounds good