search

sablier-labs / v2-merkle-api

https://v2-services.vercel.app
GNU General Public License v3.0
4 stars 0 forks source link

refactor: single crate #22

Closed PaulRBerg closed 9 months ago

PaulRBerg commented 9 months ago

Closes #6, #11, #12, and #20.

Fixes the CI by following the instructions provided here:

PTAL @gavriliumircea. If everything looks good, feel free to squash & merge.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **v2-merkle-api** | ⬜️ Ignored ([Inspect](https://vercel.com/sablier/v2-merkle-api/fukPNTdKznwkggmkDs1BGT9pvmtg)) | | Nov 24, 2023 7:06pm |
PaulRBerg commented 9 months ago

@gavriliumircea could we please disable these comments made by the Vercel bot? IIRC there's a setting in vercel.json for this

PaulRBerg commented 9 months ago

Thanks @gavriliumircea, glad to hear that it works with Vercel.

The only issue is that the CI checks didn't pass:

SCR-20231127-jtfo

I will push the fix directly to main but for future PRs, let's ensure that the CI passes before merging.

gavriliumircea commented 9 months ago

Yup, I just wanted to be able to test the vercel env as well. Right now there is a problem with the create function on the hosted env. Investigating right now

PaulRBerg commented 9 months ago

Sorry for that