search

sablier-labs / v2-merkle-api

https://v2-services.vercel.app
GNU General Public License v3.0
4 stars 0 forks source link

Allow white-space at EOF and trim if before parsing #31

Open razgraf opened 5 months ago

razgraf commented 5 months ago

One of the most common issues with CSV uploads has been that some editors (e.g. Microsoft Excel) add a white-space at EOF. This causes the content to fail our initial checks - frontend for sure, could be that the backend API may reject it as well.

We should test this assumption at both levels and try to enable this kind of files and trim the content before parsing it.

gavriliumircea commented 4 months ago

I retested multiple scenarios with EOF white Spaces, empty lines, white spaces inside the columns and the server seems to handle those cases properly. I also checked the code and the values are trimmed before being validated. Did you find a specific format that fails the validation?

razgraf commented 4 months ago

No, but it might be an app thing, hence the note to test at both levels.

gavriliumircea commented 4 months ago

I think we can close this issue because I just tested and everything seems to work just fine.