Closed PaulRBerg closed 7 months ago
I have two questions that I have been struggling to decide on:
1. For a given campaign, should we assume it to have the same segments for all users or not?
The claim
function does not need to have amount
as the input argument. We can calculate it by adding up the amounts from the segments. Am I correct?
When protocolFee > 0
, unlike MerkleStreamerLL
, we will have to collect the protocol fee in addition to the campaign total amount from the campaign creator. Then there are two approaches:
We calculate the totalAmount
as the sum of segments + protocol fee in claim
function. So while creating the stream, the net amount would match with segment amounts. This will re-introduce the Comptroller and protocol fee in the v2-periphery.
The UI calculate the segment amounts plus the protocol fee and passes it in the claim
function as amount
. So we wouldn't have to introduce the Comptroller but the calculation would be done externally. But this would introduce amount
parameter in the claim
which will require us to verify whether the amount matches the segment amount or not. Then it would again re-introduce Comptroller into v2-periphery.
How should I proceed in this case? Or we get rid of protocol fee and don't deal with the 3rd problem.
RFC from @PaulRBerg @andreivladbrg.
Good questions @smol-ninja.
Correct
I am in favor of completely removing protocol fees, see this. We just need to get Max on board with this proposal.
Closing it for now as discussed in https://github.com/sablier-labs/v2-periphery/discussions/288.
As discussed in https://github.com/sablier-labs/company-discussions/discussions/23.