fix docker-compose to bring in line with quick-start

sablierapp / sablier

Start your containers on demand, shut them down automatically when there's no activity. Docker, Docker Swarm Mode and Kubernetes compatible.

https://sablierapp.dev/

GNU Affero General Public License v3.0

1.36k stars 46 forks source link

fix docker-compose to bring in line with quick-start #137

Closed Sam-R closed 1 year ago

Sam-R commented 1 year ago

Minor fixes to the docker-compose.yml file based on the quick-start instructions in README.md.

update docker image to use acouvreur/sablier:1.3.0 as per dockerhub's tag to solve ERROR: manifest for acouvreur/sablier:v1.3.0 not found: manifest unknown: manifest unknown message on docker-compose up -d.
update container name to use underscores (default on Docker 23.0.1 on Ubuntu 22.04) to solve An error occured: Error: No such container: sablier-whoami-1 error when calling the dynamic URL in a web browser.

acouvreur commented 1 year ago

Oh you're right about the tag! I'll check for the containers names.

acouvreur commented 1 year ago

I superseded your PR changes for the version with https://github.com/acouvreur/sablier/pull/138.

Can you rebase on it once merged ?

And we should probably use container names instead of the auto assigned docker-compose ones.

What do you think?

Sam-R commented 1 year ago

Sure, I've rebased and the PR is now up to date with main.

I tend to avoid specific container names in my environments because it impacts dockers ability to scale. For the quick-start it might be okay but I wouldn't normally run named containers in pre-prod/prod.

Are you seeing different docker container name formats? I wasn't sure if that'd be the case which is why I listed my docker version and OS version.

acouvreur commented 1 year ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

v1.4.0
GitHub release

Your semantic-release bot :package::rocket: