sablierapp / sablier

Start your containers on demand, shut them down automatically when there's no activity. Docker, Docker Swarm Mode and Kubernetes compatible.
https://sablierapp.dev/
GNU Affero General Public License v3.0
1.36k stars 46 forks source link

feat(charts): sablier helm chart for kube deployement #274

Closed DrummyFloyd closed 1 week ago

DrummyFloyd commented 6 months ago

Hi , like i said i n the issue, seems to be a good idea to have a chart to easily deploy sablier

NB: not very used to work with gh-actions, double check ^^

Closed: #271

acouvreur commented 6 months ago

Hey @DrummyFloyd ! Thanks a lot for your contribution, I will look into it :)

acouvreur commented 6 months ago

I'm not familiar with what's being done in most projects, should we have a folder charts ? A folder helm ? Should we place the folder charts inside the folder helm ?

Also for all the CI part I'm not familiar with helm testing.

I'll need some time reviewing this 👍

This is some serious work though, thanks a lot for your contributions!

DrummyFloyd commented 6 months ago

I'm not familiar with what's being done in most projects, should we have a folder charts ? A folder helm ? Should we place the folder charts inside the folder helm ?

no it's quite a convention the charts folders then inside u will find all yours chart look for instance the grafana-repo but if you prefers, it up to you , just do not forget to change ct.yaml and workflows overall

Also for all the CI part I'm not familiar with helm testing.

for the CI part, is quite simple i use what i used on my own stuff + was inspired byt other open source stuff like traefik-chart if you need some explanation do not hesitate =) but for me the most important part is the unittest stuff, the ct install can be optionnal but could improve the test on the charts

This is some serious work though, thanks a lot for your contributions!

Np!

acouvreur commented 3 months ago

Hello @DrummyFloyd

I will create a new PR heavily inspired from your work.

I'll mark you as a co author on the commit and this PR will be referenced!

I'll close this PR once I'll submit the new one.

DrummyFloyd commented 3 months ago

Hello @DrummyFloyd

I will create a new PR heavily inspired from your work.

I'll mark you as a co author on the commit and this PR will be referenced!

I'll close this PR once I'll submit the new one.

Np problem =)

acouvreur commented 3 months ago

The main issue is that the current CI you are using sets up a chart repository using the github pages.

Currently the github pages feature is used to host the documentation.

I'll check what I can do.

acouvreur commented 3 months ago

We should also take car of helm best practices: https://helm.sh/docs/chart_best_practices/

There are some changes to be done for sa and rbac

acouvreur commented 3 months ago

With the way I will be deploying multi versioned documentation, this will enable me to publish the helm chart!

sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-advanced-security[bot] commented 3 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

basti-nis commented 2 months ago

Any updates on this @acouvreur We want to deploy sablier in a large EKS cluster for our customer, but we're waiting until the helm chart is merged. Thanks a lot and I appreciate your work!

acouvreur commented 2 months ago

I'm quite busy at the moment, but I think I can finish working on this next week :)

debu99 commented 1 week ago

any update

acouvreur commented 1 week ago

Hello everyone, as mentioned I will be moving this to a new organization. So I've actually baked the helm chart: https://github.com/sablierapp/helm-charts

You can start testing it! I'm sure there will be some issues but it's a first :)