kind_namespace_name_replicas error from release 1.8.0-beta.9

sablierapp / sablier

Start your containers on demand, shut them down automatically when there's no activity. Docker, Docker Swarm Mode and Kubernetes compatible.

https://sablierapp.dev/

GNU Affero General Public License v3.0

1.46k stars 48 forks source link

kind_namespace_name_replicas error from release 1.8.0-beta.9 #354

Closed gorositopablo closed 4 months ago

gorositopablo commented 4 months ago

Describe the bug

It seems like a bug was introduced from release 1.8.0-beta.9 as after that version, Sablier is no longer able anymore to terminate pods in Kubernetes and in the logs this is the message:

level=warning msg="error stopping : invalid name should be: kind_namespace_name_replicas"

Context

Sablier version: [1.8.0-beta.9] and [1.8.0-beta.10]
Provider: [e.g. kubernetes 1.28.10]
Reverse proxy: [e.g. traefik v3.0.0]
Sablier running inside a container? yes

Expected behavior Sablier should be able to terminate pods as before.

acouvreur commented 4 months ago

Can you show me more details on your configuration calling Sablier ?

I will push a change that shows the faulty value.

acouvreur commented 4 months ago

I can reproduce the issue, currently working on a fix.

acouvreur commented 4 months ago

:tada: This issue has been resolved in version 1.8.0-beta.11 :tada:

The release is available on:

v1.8.0-beta.11
GitHub release

Your semantic-release bot :package::rocket:

acouvreur commented 4 months ago

Version 1.8.0-beta.12 should fix everything.

gorositopablo commented 4 months ago

Sorry for my delay in this input @acouvreur, I just wanted to confirm that the release 1.8.0-beta.12 works perfectly. Thanks a lot.