sabnzbd / sabctools

C implementations of functions for use within SABnzbd
GNU General Public License v2.0
21 stars 11 forks source link

inconsistent license info #86

Closed jcfp closed 1 year ago

jcfp commented 1 year ago

All src/*.{cc,h} files carry GPL-2+ headers, but setup.py and LICENSE.md say LGPLv3.

Safihre commented 1 year ago

Ah yes, I don't really know anything about that.. Maybe you can fix it? 😇

jcfp commented 1 year ago

For code written by yourself and other recent contributors for sabctools, the license is your/their own choice. GPL-2+ is fine here AFAICT, although the info in the license file and setup.py should obviously match what the headers say.

Yenc as well as sabyenc were LGPL-2.1, section 3 of which explicitly permits relicensing to GPL-2 or later. Any original author's copyright remains though, so at least the parts that directly derive from the original yenc (e.g. src/yenc.cc) should retain Alessandro Duca's copyright notice (see sabyenc3.cc) alongside the sabnzbd-team's.

Then there's src/unlocked_ssl.cc, "largely copied" from current cpython which comes under the (GPL-compatible) PSF license. Best guess (as I'm not a lawyer): if you license the changes you made under GPL, the combined file is effectively subject to both licenses; the copyright notice at the top of that file should reflect that.

Edit: I'll make a PR with the suggested changes later

Safihre commented 1 year ago

Edit: I'll make a PR with the suggested changes later

Thanks :)