Leading asterisks have wrong background color in terminal Emacs

stefanavey commented 8 years ago

I'm not sure if you intended this to be compatible with Emacs run from the terminal but I see the leading stars (even when I set the hidestars startup option for org mode) because they have a black background.

When I open the same file in the GUI Emacs I do not see this black background so the leading stars are hidden and it looks clean.

org-bullets

fosskers commented 8 years ago

I use emacs strictly out of the terminal, and yeah this doesn't look so great.

Kaligule commented 8 years ago

This could help to determine if the buffer lives in a gui or in a textbased terminal.

evadnoob commented 7 years ago

I use rxvt-unicode/urxvt and I have the same issue:

◉ This is a test of org-bullets mode *○ two stars **✸ three stars

stefanavey commented 7 years ago

I was able to solve my problem a while ago. I think it was solved by redefining the org-hide face. This now works in my terminal Emacs as well (you'll have to change the color depending on your background color).

         ;; Redefine a face from org-faces.el                                                                                                           
         (defface org-hide
           '((((background light)) (:foreground "color-231"))
             (((background dark)) (:foreground "black")))
           "Face used to hide leading stars in headlines.                                                                                               
           The foreground color of this face should be 
           equal to the background color of the frame."
           :group 'org-faces)

Kaligule commented 7 years ago

@stefanavey I don't think that this alone solved the problem, since org-bullets doesn't seem to respect the org-hide face at all. It doesn't work for me. Could you provide additional information or even you init file?

Kaligule commented 7 years ago

I added a pullrequest so org-bullet does respect org-hide. Lets hope @sabof is still maintaing this repo.

Kaligule commented 7 years ago

Btw making text invisible (so that it looks like like blank space) seems to be difficult and has been discussed here.

stefanavey commented 7 years ago

@Kaligule you are right this alone won't fix it. I thought that was my fix but it's been a long time and I forgot I stopped using org-bullets (for this reason). Sorry for the confusion - I hope it gets fixed and I'd love to try it out again.

sus007 commented 6 years ago

@stefanavey @fosskers @sabof @Kaligule Guys, any updates or fixes regarding this issue ? :confused: emacs

fosskers commented 6 years ago

@sus007 I switched to spacemacs about a year ago, where org-bullets works perfectly out of the box.

I usually use the GUI mode, but I tested it quickly in the terminal and I don't see this bullets problem there either.

stefanavey commented 6 years ago

@sus007 I'm back to using org-bullets and it works fine for me (even in terminal) when using a light theme. I can reproduce your screenshot using a dark theme (where the stars are "hidden" with correct face but have grey background). Haven't tried to fix it since I normally don't use a dark background but I'll look into it if I have time.

sus007 commented 6 years ago

@stefanavey I do use dark background and I had never tested an actual dark color scheme before with Emacs. I am ok with this for the time being. :smiley: Thanks. ema

alphapapa commented 6 years ago

@sus007 I haven't seen icons in place of to-do keywords before. Do you have a source for how you did that? :)

ordicker commented 4 years ago

I got this bug when switching between themes. It was also mentioned here but wasn't resolved.

I don't think it is the same problem, whoever it is looks the same.

alphapapa commented 4 years ago

@d1cker

ordicker commented 4 years ago

@alphapapa Thanks!

sabof / org-bullets

Leading asterisks have wrong background color in terminal Emacs #16