sabof / svg-mode-line-themes

SVG-based themes for mode-line
45 stars 3 forks source link

Rename "row" as "section" or "block" #14

Open jasonm23 opened 9 years ago

jasonm23 commented 9 years ago

Since row's aren't literal rows they should be named something more fitting. e.g. section or block

sabof commented 9 years ago

Not in the table-row sense. Still they display items one after another, so the term is relevant.

jasonm23 commented 9 years ago

I think people would find it more confusing than useful. It's not a big deal to change it now since the package is woefully under-used.

If my themes packages are sucessful there'll be at least a thousand users, and some will be developing themes.

This is the only opportunity we have to reshape the API.

We should always follow the principle of least surprise. While row is valid, the context of rows and columns here is high.

I also think we can extend blocks, so that they are just things which contain widgets. (Not necessarily in column / row sense.)

Something more all-encompassing and general is more intuitive, so helps people develop with the kit.

jasonm23 commented 9 years ago

I don't mind doing the leg work, I just want to make sure I get your blessing.

sabof commented 9 years ago

I'll think about it.

sabof commented 9 years ago

Another possibility would be to make them a type of widget, that can contain other widgets. I'm not sure though how much more useful it will be than the current approach.

jasonm23 commented 9 years ago

I think that would be a nice way too.

If we have a single container object which manages its children's (as type of self) placement that would be good.

sabof commented 9 years ago

I also thought about span. Overall I doubt non-horizontal arrangements will be common, given it's a mode line.

jasonm23 commented 9 years ago

I think what I'm doing may well change that perception.

sabof commented 9 years ago

"row" still sounds better to my ears. I'll leave the ticket open, in case there are other objections.

sabof commented 9 years ago

"group" might be better, but I'd rather do the renaming after any possible functional changes.