Heavy namespace violations in curses.h

sabotage-linux / netbsd-curses

libcurses and dependencies taken from netbsd and brought into a portable shape (at least to musl or glibc)

Other

147 stars 14 forks source link

Heavy namespace violations in curses.h #39

Open richfelker opened 4 years ago

richfelker commented 4 years ago

curses.h is full of identifiers in the __-prefixed namespace, many of which are things that could easily clash with system headers. I saw a report of it failing to build on OSX that looked like it might have been related, and while I didn't see cause for that particular failure it prompted me to notice all these violations. I don't think any of them are essential/public API.

rofl0r commented 4 years ago

@rsmarples could this be addressed in netbsd upstream ?

rsmarples commented 4 years ago

Unlikely.

@richfelker is right that __ is reserved for system headers and in NetBSD curses.h is a system header and libcurses is a system library.

Saying that I'm always happy to make changes to make it more portable if there is a reported build failure, which there currently isn't.