search

saboyanosh / themissingtabwidget

Automatically exported from code.google.com/p/themissingtabwidget
Other
0 stars 0 forks source link

Issue in 9 patch land drawable #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
landscape tab does not look nice. gradient is not smooth

What steps will reproduce the problem?
- put themissingtab activity in landscape

What is the expected output? What do you see instead?
- tab color gradient should be as smooth as portrait mode

What version of the product are you using? On what operating system?
- 1.0

Please provide any additional information below.

The provided 9 patch drawable for landscape mode are not good. I have fixed 
them, if you want I can send them by  email: tlegras at gmail dot com

Also I have another layout for tab with text under icon

Thanks for this very good package!

Thierry.

Original issue reported on code.google.com by tleg...@gmail.com on 23 Jan 2011 at 11:09

GoogleCodeExporter commented 9 years ago 
Absolutely! please provide them. You can also prepare patch for it :)...

Original comment by ja...@potiuk.com on 23 Jan 2011 at 11:28

GoogleCodeExporter commented 9 years ago 
Clone the repo make the changes and let me know - then I can pull your changes 
in :).....

Original comment by ja...@potiuk.com on 23 Jan 2011 at 11:49

GoogleCodeExporter commented 9 years ago 
Here it is :)

I guess you generate the landscape icons by just rotating the landscape 9
patch png files. This is a good start, but you just missed updating the
black markers with the "draw9patch.bat" tool provided in the SDK as
described here:
http://developer.android.com/intl/fr/guide/developing/tools/draw9patch.html

I should integrate your excellent widget very soon in my application :) :
http://sites.google.com/site/freeboxrecorder/
(french only, sorry)

Original comment by tleg...@gmail.com on 23 Jan 2011 at 3:53

GoogleCodeExporter commented 9 years ago 
Ha sorry, missed that one. I hope the zip will be ok for you. Note I didn't
look at the V4 files that were in (I juste removed them to keep my apk
small), probably the same issue in it?

One additional comment: about my version of tab_indicator.xml: it is ok if
you have up to 4 tab. Else icons and text will be more or less hidden :(

Original comment by tleg...@gmail.com on 23 Jan 2011 at 3:57

GoogleCodeExporter commented 9 years ago 
Zip is fine no problem. Just attach it :)....

Original comment by ja...@potiuk.com on 23 Jan 2011 at 4:02

GoogleCodeExporter commented 9 years ago 
BTW. Your app is very nice (translated it with Google Translate and it's pretty 
much understandable what it does). Happy to help :).

Original comment by ja...@potiuk.com on 23 Jan 2011 at 4:05

GoogleCodeExporter commented 9 years ago 
Indeed it was attached as reply to your first mail
Tell me if you did not receive it.

Original comment by tleg...@gmail.com on 23 Jan 2011 at 4:17

GoogleCodeExporter commented 9 years ago 
Nope. Did not recieve it..... Seems that you need to use web interface to 
attach it - seems that code.google.com strips it out from mail ...

Original comment by ja...@potiuk.com on 23 Jan 2011 at 4:23

GoogleCodeExporter commented 9 years ago 
Sorry, did not mail attachment could not work. Should be better now.

Original comment by tleg...@gmail.com on 23 Jan 2011 at 4:43

Attachments:

GoogleCodeExporter commented 9 years ago 
Hello Thierry,

Thanks for your code. I upgraded the widget now to version 0.2. It is not a 
100% your change, it is a bit more and better :). Since I wanted to keep both 
modes of showing landscape widget I added two modes of running the widget:
 * default - it runs with icons left of the title
 * pictures above title - your version :)

One can choose which mode the host should be run with by running 
setLandscapePicturesAboveTitles(boolean) right after retrieving 
TheMissingTabHost.... By default icons are on left. The method is here: 
http://code.google.com/p/themissingtabwidget/source/browse/src/pl/polidea/custom
widget/TheMissingTabHost.java#108

If you are using your own xml layout to place the tab host in you can also 
specify it with the custom XML attribute (first custom attribute for me ;) ). 
You can see how it is done in 
http://code.google.com/p/themissingtabwidget/source/browse/res/layout-land/tab_c
ontent.xml

I put extra pictures at the main page to show it: 
http://code.google.com/p/themissingtabwidget/

I also created release notes: 
http://code.google.com/p/themissingtabwidget/wiki/ReleaseNotes

and updated usage guide: 
http://code.google.com/p/themissingtabwidget/wiki/UsageGuide

to reflect the changes. 

Hope you don't mind I referred to you and your project ;) (and please let me 
know when your project gets released - I am happy that someone found a bit of 
my work useful). 

Best regards, 

Jarek

Original comment by ja...@potiuk.com on 23 Jan 2011 at 7:09

GoogleCodeExporter commented 9 years ago 
Wow, good job, very pro! The custom attribute trick is nice, did not know
about that.

One suggestion: as an alternative to setLandscapePicturesAboveTitle, maybe
if not already possible, it would be nice to have an another option which
allows to specify a custom layout for tab indicator like
setCustomTabIndicatorLayout(int ResLayoutId). I saw many questions related
to tabactivity about guies who wanted to customize the layout (change the
color, make it smaller, etc.). Indeed I will probably do that later.
Providing some default layouts like you do now is very good because it gives
something nice and working out of the box. But further customization would
be a plus :)

One remark: there seems to be a problem in the tab indicator color my land
layout: it is much too light compared to portrait. I will check that.

Thanks for refering my app. I will also add you in my "about" window in the
third party section ;)
(still need to list them in my web site too)
I should release the new version in a few weeks. I still have some work to
save states when orientation change. Before, I used to prevent activity
recreation during orientation changes with
android:configChanges="orientation" in my Manifest. But as I want now a nice
landscape layout for tablet, it is time to sort all this out :)

Original comment by tleg...@gmail.com on 24 Jan 2011 at 9:43

GoogleCodeExporter commented 9 years ago 
Good idea indeed. So far, just replace the resource. BTW. I think I will change 
integration way for the project so that you can use it as shared library rather 
than copy the code. I use this successfuly with another small project I  just 
released ( http://code.google.com/p/android-flip3d/ ) (well it lacks a bit of 
documentation still but it will be soon updated) ....

Original comment by ja...@potiuk.com on 25 Jan 2011 at 10:43