search

sabre-io / Baikal

Baïkal is a Calendar+Contacts server
https://sabre.io/baikal/
GNU General Public License v3.0
2.44k stars 282 forks source link

[bug] Only the name of an event's location is saved, not the address for that location. #1177

Closed lightmaster closed 1 year ago

lightmaster commented 1 year ago

Baikal version: 0.9.3

Expected behaviour: When using a Google-hosted calendar (the normal one that comes with your Google account), when you set a location for an event, you can see the name of the Location, followed by the Address for that Location. Google Calendar also sets the top of the event to be a photo pulled from the Google Maps places for the Location. When you click on the Location, it immediately takes you to the Google Maps place corresponding to the Location you set.

I would expect that setting a Location for an event with Baikal would also save the name and address for the Location, so that clicking on the Location pulls up the Location's place directly. I'm not sure how Google Calendar handles the image of the place, so I don't know if saving the name and address of a Location would automatically handle the image as well, but that is more of a "nice-to-have", whereas properly saving the Location's name and address is a critical issue.

Current behaviour: After saving a Location to an event, only the name of the Location is saved, not the address. Therefore clicking on the Location in the event only pulls up a search for places with that name, not taking you directly to that Location. If this Location isn't near to where you are and has a fairly generic/common name, then it won't even show up when Calendar tries to search for the Location. For instance, say that I am in Atlanta, GA and I create an event with a Location for "Walmart Supercenter" in Jacksonville, FL. Prior to saving the event, Calendar does show the correct name and address for the Location, but after saving and when I open the event back up again, all the Location says is "Walmart Supercenter" and when I click on the Location, it has no address or city information saved for the Location, so it does a Google Maps search for "Walmart Supercenter" in my surrounding area.

Currently, the only way to save any Location information that could be remembered at a later time is to add the address as text to the description, and then you can do a manual search for it when needed.

Steps to reproduce:

  1. Create an event with a Location saved to the event
  2. Observe that your calendar app shows a Location name and address prior to saving
  3. Observe that after saving and opening that event up again, only the Location name is actually saved, and clicking on the Location in the event only does a local search for the name of the Location

https://user-images.githubusercontent.com/5307827/223602445-4ff83d7f-9569-4d56-af09-a7e9c0bfac4e.mp4

ByteHamster commented 1 year ago

That's an issue with your calendar app, not with Baikal. The Google calendar app does not add the address to non-Google events.

lightmaster commented 1 year ago

Not sure how I missed this reply. Are there any Android Calendar apps that are known to correctly save the location data?

ByteHamster commented 1 year ago

I have never tested different calendar apps and I don't use this feature, so I don't know. Let me know if you find an app that does it :)