sabre-io / Baikal

Baïkal is a Calendar+Contacts server
https://sabre.io/baikal/
GNU General Public License v3.0
2.44k stars 282 forks source link

How to install from latest sources and not a release build #1207

Closed PhilZ-cwm6 closed 10 months ago

PhilZ-cwm6 commented 10 months ago

Hi

Except manually patching the files by comparing them, is there a proper way to build a release package from the current sources that includes both baikal, dav and proprietary files ? If I only patch the changed files manually and keep the other propretary files from teh old release, is it a safe approach ?

Thank you for the help

ByteHamster commented 10 months ago

The release zip is generated by make dist. Patching only selected files will probably lead to issues if you forget a version bump or similar. See upgrade instructions here: https://sabre.io/baikal/upgrade/

PhilZ-cwm6 commented 9 months ago

@ByteHamster Thank you. However, the build always catches the dav release specified in composer.json and not latest dav source changes ! I updated composer.json from "sabre/dav" : "~4.3.0", to "sabre/dav" : "~4.4.0",

Still I cannot figure how to force it using latest dav sources and not the github release I tried to replace files under local directory Baikal/vendor/sabre/dav with latest sources. However, composer ignores them in the released zip file

Should I patch the vendor/sabre/dav files manually ?

Thank you a lot

PhilZ-cwm6 commented 9 months ago

ok, I figure it out. In composer.json I edited "sabre/dav" : "~4.3.0", to "sabre/dav" : "dev-master", The final make dist release is missing this file: .php_cs.dist

Is it a mandatory one or I am fine with my builds ?

Thank you

ByteHamster commented 9 months ago

I have never tried running dev versions of sabre/dav. Be careful when a new sabre/dav version needs database migrations. Baikal only upgrades the database with an actual Baikal update, not with dependency updates. I would probably rather pin sabre/dav to a specific commit

PhilZ-cwm6 commented 9 months ago

I did not think at this. Thank you for the warning