sabre-io / cache

:handbag: Simple cache abstraction layer implementing PSR-16

BSD 3-Clause "New" or "Revised" License

54 stars 10 forks source link

Use latest php-cs-fixer 2.17.1 #33

Closed phil-davis closed 3 years ago

phil-davis commented 3 years ago

The latest php-cs-fixer finds some new things. Code changes were needed in https://github.com/sabre-io/dav/pull/1316 for sabre/dav. We might as well consistently make sure to use at least this version 2.17.1 in all repos so that we are doing consistent code-style checking.

It complains about comments at the end of lines in the class definition. I removed those and wrote some words in the main comment block.

phil-davis commented 3 years ago

https://travis-ci.org/github/sabre-io/cache/jobs/749389769 - first run failed:

PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
.............................FF.........S........................ 65 / 72 ( 90%)
.......                                                           72 / 72 (100%)
Time: 12.32 seconds, Memory: 6.00 MB
There were 2 failures:
1) Sabre\Cache\MemcachedTest::testSetExpire
Failed asserting that null matches expected 'bar'.
/home/travis/build/sabre-io/cache/tests/Cache/AbstractCacheTest.php:73
2) Sabre\Cache\MemcachedTest::testSetExpireDateInterval
Failed asserting that null matches expected 'bar'.
/home/travis/build/sabre-io/cache/tests/Cache/AbstractCacheTest.php:88
FAILURES!
Tests: 72, Assertions: 208, Failures: 2, Skipped: 1.

All the other CI jobs passed. I have a feeling that there are time-dependent test cases that can "randomly" fail.

And it passes the 2nd time - issue #15

codecov[bot] commented 3 years ago

Codecov Report

Merging #33 (b8109b8) into master (b018789) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff             @@
##              master       #33   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        79        79           
===========================================
  Files              4         4           
  Lines            150       150           
===========================================
  Hits             150       150

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b018789...b8109b8. Read the comment docs.