phil-davis commented 3 years ago

This PR is really an excuse to make the new GitHub workflows run, and get them passing.

1) correct some minor typos 2) add a return to the end of deleteMultiple which was missing (report by code analysis) 3) Setup memcached server and apcu for tests

This makes all 72 unit tests run and pass, like they did with Travis.

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (c0c96ca) into master (6d4bb32) will increase coverage by 73.81%. The diff coverage is 100.00%.

:exclamation: Current head c0c96ca differs from pull request most recent head 188dd9e. Consider uploading reports for the commit 188dd9e to get more accurate results

@@              Coverage Diff              @@
##             master      #36       +/-   ##
=============================================
+ Coverage     24.88%   98.69%   +73.81%     
  Complexity       79       79               
=============================================
  Files             4        4               
  Lines           209      153       -56     
=============================================
+ Hits             52      151       +99     
+ Misses          157        2      -155

Impacted Files	Coverage Δ
lib/Memcached.php	`100.00% <100.00%> (+100.00%)`	:arrow_up:
lib/Apcu.php	`100.00% <0.00%> (+100.00%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d4bb32...188dd9e. Read the comment docs.

phil-davis commented 3 years ago

Note: https://travis-ci.org/github/sabre-io/cache/jobs/748709562

Previous CI ran all 72 unit tests, none were skipped. I need to sort out how to achieve that...

phil-davis commented 3 years ago

https://github.com/sabre-io/cache/runs/4090179189?check_suite_focus=true OK (72 tests, 218 assertions)

Good stuff.

sabre-io / cache

Correct some minor typos and get unit tests running correctly #36

Codecov Report