search

sabre-io / dav

sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP
http://sabre.io
BSD 3-Clause "New" or "Revised" License
1.52k stars 345 forks source link

Error PHP "continue" targeting switch is equivalent to "break" #1135

Open eehmke opened 5 years ago

eehmke commented 5 years ago

This error pops up for two files in the nextcloud log:

3rdparty/sabre/vobject/lib/Component/VCard.php#514 3rdparty/sabre/dav/lib/CalDAV/ICSExportPlugin.php#321

replacing the continue statement by "continue 2" solves this, but maybe it shoule be a break?

DeepDiver1975 commented 5 years ago

Which php version are you running?

staabm commented 5 years ago

IIRC this is a new error/warning with php 7.3

matejsvajger commented 5 years ago

I sent the pull request for php 7.3 fix that resolves this issue in sabre/dav:3.2 branch.

Until it's merged I aliased the repository in my composer.json:

    "require": {
        "sabre/dav": "^3.2"
    },
    "repositories": [  
        {  
            "type": "vcs",  
            "url": "https://github.com/koerbler/dav"  
        }  
    ]