Sabre_CardDAV_Plugin::getSupportedReportSet should check against interface Sabre_CardDAV_IAddressBook

[evert]

Original author: lars.kne...@gmail.com (September 13, 2011 21:17:22)

The function Sabre_CardDAV_Plugin::getSupportedReportSet checks against the class Sabre_CardDAV_AddressBook but should better check against Sabre_CardDAV_IAddressBook to allow reimplementation of the addressbook class.

--- Sabre/CardDAV/Plugin.php 2011-08-24 11:40:26.000000000 +0200 +++ Sabre/CardDAV/Plugin.php 2011-09-13 23:11:22.444819527 +0200 @@ -95,7 +95,7 @@ public function getSupportedReportSet($uri) {

     $node = $this->server->tree->getNodeForPath($uri);

• if ($node instanceof Sabre_CardDAV_AddressBook || $node instanceof Sabre_CardDAV_ICard) {
• if ($node instanceof Sabre_CardDAV_IAddressBook || $node instanceof Sabre_CardDAV_ICard) { return array( '{' . self::NS_CARDDAV . '}addressbook-multiget', '{' . self::NS_CARDDAV . '}addressbook-query',

Original issue: http://code.google.com/p/sabredav/issues/detail?id=148

[evert]

From evert...@gmail.com on September 19, 2011 14:07:44: Thanks for this report

[evert]

From evert...@gmail.com on September 19, 2011 14:08:54: This issue was closed by revision 9742b711db41.