search

sabre-io / dav

sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP
http://sabre.io
BSD 3-Clause "New" or "Revised" License
1.53k stars 346 forks source link

Add Sabre_CalDAV_ICalendar and Sabre_CalDAV_ICalendarObject #142

Closed evert closed 12 years ago

evert commented 12 years ago

Original author: lars.kne...@gmail.com (September 19, 2011 14:23:34)

The code shuold check against interfaces instead of Sabre_CalDAV_Calendar and Sabre_CalDAV_CalendarObject.

I added 2 new interfaces and modified the code to always check against the interfaces instead of the classes. I simply searched and replaced Sabre_CalDAV_Calendar and Sabre_CalDAV_CalendarObject where appropriate..

This way the CalDAV code works the same way like the CardDAV code.

Original issue: http://code.google.com/p/sabredav/issues/detail?id=151

evert commented 12 years ago

From evert...@gmail.com on September 19, 2011 22:46:41: Makes total sense. Been wanting to make this change anyway.

evert commented 12 years ago

From evert...@gmail.com on September 19, 2011 22:54:14: This issue was closed by revision 1d690b9ef267.

evert commented 12 years ago

From evert...@gmail.com on September 19, 2011 22:57:06: Just made this change. Would you mind doing a review to see if I missed anything?

evert commented 12 years ago

From lars.kne...@gmail.com on September 20, 2011 03:00:17: Looks good to me.