search

sabre-io / dav

sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP
http://sabre.io
BSD 3-Clause "New" or "Revised" License
1.52k stars 344 forks source link

fix: restore autoPrefix property of Href #1514

Closed phil-davis closed 10 months ago

phil-davis commented 10 months ago

use of this property in code was removed in PR https://github.com/sabre-io/dav/pull/801 But the property is left here because old data may still exist that has this property saved.

See discussion in https://github.com/sabre-io/Baikal/issues/1154

Fixes https://github.com/sabre-io/Baikal/issues/1154 and related issue #1445

phil-davis commented 10 months ago

If this is the accepted fix, then I will backport it to 4.5 and make a 4.5.1 release.

DeepDiver1975 commented 10 months ago

Was is always protected? I don't know right now if unserialize has issues with property access.....

phil-davis commented 10 months ago

Was is always protected? I don't know right now if unserialize has issues with property access.....

I copied from what was deleted in: https://github.com/sabre-io/dav/pull/801/files#diff-abad1406d5405d56e66aa47e67d2277a2707befef8d570f871a2c243676729b0

DeepDiver1975 commented 10 months ago

just looked it up - serialize/unserialize require the access level to be unchanged. Since this is the case I think we can safely merge this.

phil-davis commented 10 months ago

Backported to 4.5 branch in PR #1515