search

sabre-io / dav

sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP
http://sabre.io
BSD 3-Clause "New" or "Revised" License
1.54k stars 347 forks source link

feat: add propFindUnfiltered public method to Client (4.6) #1526

Closed phil-davis closed 11 months ago

phil-davis commented 11 months ago

backport of #1519

To preserve backward-compatibility I added the last commit https://github.com/sabre-io/dav/pull/1526/commits/db80aae6119e95c900575b516817a0bdf91bc8fc in addition to all the commits from master.

The original client propFind function needs to preserve its existing untyped parameters to be strictly backward-compatible.

I added some unit test cases to check what happens when $url is passed as an int (a file called "123456" might be passed as the integer 123456), and what happens when depth of 1 is passes as the string "1". We should let callers still be able to do those things in the current release series.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (4.6@f2fa433). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.6 #1526 +/- ## ====================================== Coverage ? 97.32% Complexity ? 2836 ====================================== Files ? 175 Lines ? 9433 Branches ? 0 ====================================== Hits ? 9181 Misses ? 252 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.