search

sabre-io / dav

sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP
http://sabre.io
BSD 3-Clause "New" or "Revised" License
1.54k stars 347 forks source link

allowAccessToNodesWithoutACL - Missing IACLs #1547

Closed bravedave closed 2 weeks ago

bravedave commented 8 months ago

I can see this has been discussed before in issue #788, and the code appears to work

But in PHP 8.2: Dynamic Properties are deprecated

the documentation at https://sabre.io/dav/acl/

has an example:

    $aclPlugin = new \Sabre\DAVACL\Plugin();
    $aclPlugin->allowAccessToNodesWithoutACL = false;

allowAccessToNodesWithoutACL is an undefined property

Issue #788 mentions there is another way to do it

so the question is - what would be the correct way to do it now ?

DeepDiver1975 commented 8 months ago

from the changelog in the original change back in 2016: https://github.com/sabre-io/dav/pull/815/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR25